Signature image generator - bug tracking and information

Where should the web site go - what should we do? Who has the time between rows?

Moderator: The forum police - (nee naw)

User avatar
Pepe
Best Friend (PayPal Subscriber)
Best Friend (PayPal Subscriber)
Posts: 906
Joined: Mon Oct 23, 2006 10:30 pm
I row on...: Model D with PM3
Location: Torquay, VIC Australia

Re: Signature image generator - bug tracking and information

Post by Pepe »

Hi Jon
I was trying to create a new signature in the same style as yours, i.e. showing PB, PB year, SB etc.
The error code came up when I was logged ON to FS. However, when I was logged OUT, I was able to access the generator and enter times.
So far, I have managed to submit the example sig. generator (now deleted), so there is a little progress!
I shall keep experimenting and hopefully get it right in due course.
Philip Price 90 Lwt. 70 kg. 176 cm. “Rather than rust I’ll wear out.”
User avatar
JonT
Friend of the Free Spirits web site 2020
Friend of the Free Spirits web site 2020
Posts: 2065
Joined: Tue Nov 11, 2014 2:31 pm
I row on...: Model D with PM5
Location: Bath, Somerset, UK

Re: Signature image generator - bug tracking and information

Post by JonT »

Pepe wrote: Fri Jun 16, 2023 7:11 am Hi Jon
I was trying to create a new signature in the same style as yours, i.e. showing PB, PB year, SB etc.
The error code came up when I was logged ON to FS. However, when I was logged OUT, I was able to access the generator and enter times.
So far, I have managed to submit the example sig. generator (now deleted), so there is a little progress!
I shall keep experimenting and hopefully get it right in due course.
Is this the first signature you have ever generated? That may be what the code is not handling properly, and would explain why it falls over when trying to count entries in a table that doesn't exist yet.

Jon
57 years old, 5"10', clinging on to 75kg and frustratingly but understandably inconsistent
Image
User avatar
Pepe
Best Friend (PayPal Subscriber)
Best Friend (PayPal Subscriber)
Posts: 906
Joined: Mon Oct 23, 2006 10:30 pm
I row on...: Model D with PM3
Location: Torquay, VIC Australia

Re: Signature image generator - bug tracking and information

Post by Pepe »

Yes, it is.
Philip Price 90 Lwt. 70 kg. 176 cm. “Rather than rust I’ll wear out.”
User avatar
Pepe
Best Friend (PayPal Subscriber)
Best Friend (PayPal Subscriber)
Posts: 906
Joined: Mon Oct 23, 2006 10:30 pm
I row on...: Model D with PM3
Location: Torquay, VIC Australia

Re: Signature image generator - bug tracking and information

Post by Pepe »

Hi Jon
To solve the problem with the signature image generator, I’ve devised a workaround by making my own.
So, job done; no worries :fsbgrin:
All the best and many thanks for all the work you do “under the bonnet” in keeping the technical side of FS going.
Philip
fs sig- gen.jpg
fs sig- gen.jpg (145.59 KiB) Viewed 4959 times
Philip Price 90 Lwt. 70 kg. 176 cm. “Rather than rust I’ll wear out.”
User avatar
JonT
Friend of the Free Spirits web site 2020
Friend of the Free Spirits web site 2020
Posts: 2065
Joined: Tue Nov 11, 2014 2:31 pm
I row on...: Model D with PM5
Location: Bath, Somerset, UK

Re: Signature image generator - bug tracking and information

Post by JonT »

Pepe wrote:Hi Jon
To solve the problem with the signature image generator, I’ve devised a workaround by making my own.
So, job done; no worries :fsbgrin:
All the best and many thanks for all the work you do “under the bonnet” in keeping the technical side of FS going.
Philip
Now you just need to offer that service to anyone who needs a signature and hasn’t got one yet, and we are all sorted. Image

Jon


Sent from my iPhone using Tapatalk
57 years old, 5"10', clinging on to 75kg and frustratingly but understandably inconsistent
Image
User avatar
Pepe
Best Friend (PayPal Subscriber)
Best Friend (PayPal Subscriber)
Posts: 906
Joined: Mon Oct 23, 2006 10:30 pm
I row on...: Model D with PM3
Location: Torquay, VIC Australia

Re: Signature image generator - bug tracking and information

Post by Pepe »

Jon wrote:
Now you just need to offer that service to anyone who needs a signature and hasn’t got one yet, and we are all sorted O:)
I think that the most appropriate advice to anyone in this position would be “caveat emptor” :lol:
Philip
Philip Price 90 Lwt. 70 kg. 176 cm. “Rather than rust I’ll wear out.”
User avatar
JonT
Friend of the Free Spirits web site 2020
Friend of the Free Spirits web site 2020
Posts: 2065
Joined: Tue Nov 11, 2014 2:31 pm
I row on...: Model D with PM5
Location: Bath, Somerset, UK

Re: Signature image generator - bug tracking and information

Post by JonT »

I have had a quick poke around while away on holiday ( #-o ) and I can see where there is an error in the code. Probably best if I don't try to fix this until I get home and have easy access to all of the tools that I use to manage the site.

Philip - I am assuming that if you tried to create a signature using the tool you would still get the error message? Can you check for me, that way you will be able to tell me if I have fixed the code or not.

Jon
57 years old, 5"10', clinging on to 75kg and frustratingly but understandably inconsistent
Image
User avatar
Pepe
Best Friend (PayPal Subscriber)
Best Friend (PayPal Subscriber)
Posts: 906
Joined: Mon Oct 23, 2006 10:30 pm
I row on...: Model D with PM3
Location: Torquay, VIC Australia

Re: Signature image generator - bug tracking and information

Post by Pepe »

JonT wrote: Tue Jun 20, 2023 7:50 pm Philip - I am assuming that if you tried to create a signature using the tool you would still get the error message? Can you check for me, that way you will be able to tell me if I have fixed the code or not.
Jon
Hi Jon
Yes, l’m still getting the error message when logged in to FS.
Philip
Philip Price 90 Lwt. 70 kg. 176 cm. “Rather than rust I’ll wear out.”
User avatar
stumpy
Super Dedicated and Truly Free Spirit
Posts: 3096
Joined: Sat Jul 19, 2008 5:50 pm
I row on...: Model E with PM5
Location: Bower Hinton, Somerset.

Re: Signature image generator - bug tracking and information

Post by stumpy »

Is this broken? or is it me doing it wrong trying to update my seasons bests.
71 191cm
Image
User avatar
JonT
Friend of the Free Spirits web site 2020
Friend of the Free Spirits web site 2020
Posts: 2065
Joined: Tue Nov 11, 2014 2:31 pm
I row on...: Model D with PM5
Location: Bath, Somerset, UK

Re: Signature image generator - bug tracking and information

Post by JonT »

stumpy wrote: Fri Mar 22, 2024 10:46 am Is this broken? or is it me doing it wrong trying to update my seasons bests.
It was broken after I had upgraded the website software Colin, but I thought I had fixed it. It is working for me. Can you tell me what the issue is that you are having? It looks like you have tried to add a screenshot to your post, but I can’t see it.

Jon
57 years old, 5"10', clinging on to 75kg and frustratingly but understandably inconsistent
Image
User avatar
stumpy
Super Dedicated and Truly Free Spirit
Posts: 3096
Joined: Sat Jul 19, 2008 5:50 pm
I row on...: Model E with PM5
Location: Bower Hinton, Somerset.

Re: Signature image generator - bug tracking and information

Post by stumpy »

Thx Jon it was me, sorted now I was trying to edit an old post.
71 191cm
Image
User avatar
FXST01
Warming up
Posts: 4
Joined: Thu Jul 04, 2024 8:18 am
I row on...: Model D with PM3
Location: Perth WA

Re: Signature image generator - bug tracking and information

Post by FXST01 »

Hello JonT,

I'm getting this error:

Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /home/fssandbox/www/www/fs/signatures/sig-genpage.php:158 Stack trace: #0 /home/fssandbox/www/www/fs/signatures/index.php(3): include() #1 {main} thrown in /home/fssandbox/www/www/fs/signatures/sig-genpage.php on line 158

works ok if I don't log in.

regards,

Eddie
Image
User avatar
JonT
Friend of the Free Spirits web site 2020
Friend of the Free Spirits web site 2020
Posts: 2065
Joined: Tue Nov 11, 2014 2:31 pm
I row on...: Model D with PM5
Location: Bath, Somerset, UK

Re: Signature image generator - bug tracking and information

Post by JonT »

Hi Eddie,

Thanks for letting me know. This is a very old piece of code that was written before I took over the site. I suspect you are the first new member to use it since I had to do a major upgrade to it as an overhaul to the entire site last year. The good news is that I can recreate the problem using a test user and so should be able to get to the bottom of it. I'll post back here when I have had time to take a look. I'm not sure how long it will take I'm afraid.

Jon
57 years old, 5"10', clinging on to 75kg and frustratingly but understandably inconsistent
Image
User avatar
JonT
Friend of the Free Spirits web site 2020
Friend of the Free Spirits web site 2020
Posts: 2065
Joined: Tue Nov 11, 2014 2:31 pm
I row on...: Model D with PM5
Location: Bath, Somerset, UK

Re: Signature image generator - bug tracking and information

Post by JonT »

FXST01 wrote: Thu Jul 04, 2024 6:10 pm I'm getting this error:

Fatal error: Uncaught TypeError: count(): Argument #1 ($value) must be of type Countable|array, null given in /home/fssandbox/www/www/fs/signatures/sig-genpage.php:158 Stack trace: #0 /home/fssandbox/www/www/fs/signatures/index.php(3): include() #1 {main} thrown in /home/fssandbox/www/www/fs/signatures/sig-genpage.php on line 158

works ok if I don't log in.
Eddie, I think I found the, relatively simple, bug. As I suspected there was some code which made all kinds of assumptions about how the system behaves when things go wrong (e.g. a new user not having any entries) which are no longer true on the new version of the software we use.

Let me know if I have fixed it. If I have broken things for others then I'm sure someone will let me know.

Jon
57 years old, 5"10', clinging on to 75kg and frustratingly but understandably inconsistent
Image
User avatar
FXST01
Warming up
Posts: 4
Joined: Thu Jul 04, 2024 8:18 am
I row on...: Model D with PM3
Location: Perth WA

Re: Signature image generator - bug tracking and information

Post by FXST01 »

All fixed, thanks JonT.

regards

Eddie
Image
User avatar
JonT
Friend of the Free Spirits web site 2020
Friend of the Free Spirits web site 2020
Posts: 2065
Joined: Tue Nov 11, 2014 2:31 pm
I row on...: Model D with PM5
Location: Bath, Somerset, UK

Re: Signature image generator - bug tracking and information

Post by JonT »

FXST01 wrote: Fri Jul 05, 2024 2:42 pm All fixed, thanks JonT.
Great. Thanks for letting me know.

Jon
57 years old, 5"10', clinging on to 75kg and frustratingly but understandably inconsistent
Image
Post Reply